Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #6554/29790df5 backport][stable-7] Don't require api_password when api_token_id is used in proxmox_tasks_info #6562

Merged
merged 1 commit into from
May 22, 2023
Merged

[PR #6554/29790df5 backport][stable-7] Don't require api_password when api_token_id is used in proxmox_tasks_info #6562

merged 1 commit into from
May 22, 2023

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented May 22, 2023

This is a backport of PR #6554 as merged into main (29790df).

SUMMARY

Fixes #6201.

As api_user is always required then using it in required_together constraint leads to unwanted behavior when api_password is also always needed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_tasks_info

ADDITIONAL INFORMATION

Output Before the change

fatal: [localhost]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "api_host": "localhost",
            "api_password": null,
            "api_token_id": "root-token",
            "api_token_secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "api_user": "root@pam",
            "node": "pve",
            "task": null,
            "validate_certs": false
        }
    },
    "msg": "parameters are required together: api_user, api_password"
}

Output After

ok: [localhost] => {
    "changed": false,
    "invocation": {
        "module_args": {
            "api_host": "localhost",
            "api_password": null,
            "api_token_id": "root-token",
            "api_token_secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "api_user": "root@pam",
            "node": "pve",
            "task": null,
            "validate_certs": false
        }
    },
    "proxmox_tasks": []
}

@UnderGreen @patchback
Don't require api_password when api_token_id is used in proxmox_tasks…
22a53bd 
…_info (#6554)

* Don't require api_password when api_token_id is used in proxmox_tasks_info

* Add changelog fragment

* Fix casing.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 29790df)
@patchback patchback bot mentioned this pull request May 22, 2023
Merged
@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @joshainglis @karmab @paginabianca @tleguern
click here for bot help

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) labels May 22, 2023
@felixfontein felixfontein merged commit 45d3708 into stable-7 May 22, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-7/29790df583ff5b7c6d0487bde57e27e37e9c423f/pr-6554 branch May 22, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @felixfontein @UnderGreen